-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove/Reduce lodash usage #41
Comments
Furthermore, since you are already dropped support for old node versions, you can also get rid of |
I know, unfortunately haven't had the time. I wanted to completely get rid of flattenDeep but then got distracted by other work. Maybe i'll do this as a intermediate solution. 🤔 |
I think dropping 2 deps for 1 micro would be enough for now. |
Also if you wanna be a total bro adding TypeScript typings would be awesome! |
Hah! As i‘m heavily relying on Flow for my own projects (i took over maintenance for this project, so it‘s not my „own“ codebase) i tried to add flowtypes to this aswell, but this code is mutating existing prototypes/classes that aren’t really typed to be modified. It should be possible to create a library definition, though. As i’m not familiar with TypeScript i won’t create one for TypeScript but others are free to contribute one, but i’m not entirely sure what the TypeScript way to do is (include in npm module or contribute to DefinitelyTyped). |
I just rechecked and |
See v3.0.0-rc.1 |
This is now released and TypeScript definitions have been added as well (#47) |
You are only using 2 of lodash's function, one can be replaced with a
for in
loop, the other can be replaced with https://www.npmjs.com/package/lodash.flattendeep.The text was updated successfully, but these errors were encountered: