Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: requestWasSuccessful usage doesn't support returning a Promise #426

Merged
merged 2 commits into from Nov 27, 2023
Merged

Bugfix: requestWasSuccessful usage doesn't support returning a Promise #426

merged 2 commits into from Nov 27, 2023

Conversation

azjgard
Copy link
Contributor

@azjgard azjgard commented Nov 27, 2023 •
edited

Fixes #425

The added test case fails on main but succeeds on this branch.

@nfriedly
Copy link
Member

Oh, good catch, thank you!

@nfriedly nfriedly merged commit eee94f1 into express-rate-limit:main Nov 27, 2023
13 checks passed
@nfriedly
Copy link
Member

Should be released as v7.1.5 shortly.

@azjgard
Copy link
Contributor Author

azjgard commented Nov 27, 2023

So quick, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

requestWasSuccessful usage doesn't support returning a Promise
2 participants
@azjgard @nfriedly