Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): support express 5 #51

Merged
merged 1 commit into from
May 5, 2024

Conversation

dderevjanik
Copy link
Contributor

@dderevjanik dderevjanik commented May 4, 2024

This pull request addresses an issue with dependency resolution in the express-slow-down package. Currently, the package specifies a peer dependency on Express >= 4, which leads to conflicts when installed in projects using Express 5.0.0-beta.3 or higher.

Error log when installing on project with express 5

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: myproject@1.0.0
npm ERR! Found: express@5.0.0-beta.3
npm ERR! node_modules/express
npm ERR!   express@"5.0.0-beta.3" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer express@">= 4" from express-slow-down@2.0.1
npm ERR! node_modules/express-slow-down
npm ERR!   express-slow-down@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

@gamemaker1 gamemaker1 changed the title chore: support express 5 chore(deps): support express 5 May 5, 2024
@gamemaker1 gamemaker1 merged commit 9277ffb into express-rate-limit:master May 5, 2024
10 checks passed
@gamemaker1
Copy link
Member

Thank you!

@dderevjanik dderevjanik mentioned this pull request May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants