Schema: ignore validator if its value is falsy

Closes #263
express-validator · Jul 9, 2017 · 817af05 · 817af05
1 parent 77299b9
commit 817af05
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 4 deletions.
diff --git a/lib/express_validator.js b/lib/express_validator.js
@@ -217,10 +217,9 @@ var expressValidator = function(options) {
           continue;
         }
 
-        if (methodName === 'errorMessage') {
-          /* Also do not validate if methodName
-          * represent parameter error message
-          */
+        if (methodName === 'errorMessage' || !schema[param][methodName]) {
+          // Also do not validate if methodName represent parameter error message
+          // or if the value is falsy
           continue;
         }
 

diff --git a/test/schema.spec.js b/test/schema.spec.js
@@ -96,4 +96,24 @@ describe('Schema validation', () => {
       expect(result.mapped()).to.eql({});
     });
   });
+
+  it('ignores validators which values are falsy', () => {
+    const req = {
+      body: {
+        int: 'asd',
+        upper: 'qwe'
+      }
+    };
+
+    expressValidator()(req, {}, () => {});
+    req.check({
+      int: { isInt: true },
+      upper: { isUppercase: false }
+    });
+
+    return req.getValidationResult().then(result => {
+      expect(result.mapped()).to.have.property('int');
+      expect(result.mapped()).to.not.have.property('upper');
+    });
+  });
 });