feat(oneOf): add new error types #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedeci
commented
Apr 21, 2021
src/middlewares/one-of.ts
Outdated
| @@ -9,16 +9,19 @@ const dummyItem: ContextItem = { async run() {} }; | |||
|
|
|||
| export type OneOfCustomMessageBuilder = (options: { req: Request }) => any; | |||
|
|
|||
| export type OneOfErrorType = 'grouped' | 'leastErroredOnly' | 'legacy'; | |||
There was a problem hiding this comment.
Not sure about leastErroredOnly name, any suggestion?
There was a problem hiding this comment.
I like the name grouped as it describes well the behaviour.
What do you think of flat instead of legacy? It sounds exactly like the opposite of grouped.
As for leastErroredOnly... still no better ideas 😢
gustavohenke
requested changes
Jun 22, 2021
src/middlewares/one-of.ts
Outdated
| @@ -9,16 +9,19 @@ const dummyItem: ContextItem = { async run() {} }; | |||
|
|
|||
| export type OneOfCustomMessageBuilder = (options: { req: Request }) => any; | |||
|
|
|||
| export type OneOfErrorType = 'grouped' | 'leastErroredOnly' | 'legacy'; | |||
src/middlewares/one-of.ts
Outdated
| @@ -9,16 +9,19 @@ const dummyItem: ContextItem = { async run() {} }; | |||
|
|
|||
| export type OneOfCustomMessageBuilder = (options: { req: Request }) => any; | |||
|
|
|||
| export type OneOfErrorType = 'grouped' | 'leastErroredOnly' | 'legacy'; | |||
There was a problem hiding this comment.
I like the name grouped as it describes well the behaviour.
What do you think of flat instead of legacy? It sounds exactly like the opposite of grouped.
As for leastErroredOnly... still no better ideas 😢
fedeci
force-pushed
the
one-of-error-messages
branch
from
c71a8a5
to
540ead2
Compare
fedeci
commented
Jul 18, 2021
src/middlewares/one-of.ts
Outdated
Comment on lines
14
to
21
| message?: OneOfCustomMessageBuilder, | ||
| options: { message: OneOfCustomMessageBuilder; errorType?: OneOfErrorType }, | ||
| ): Middleware & { run: (req: Request) => Promise<void> }; | ||
| export function oneOf( | ||
| chains: (ValidationChain | ValidationChain[])[], | ||
| message?: any, | ||
| options: { message?: any; errorType?: OneOfErrorType }, | ||
| ): Middleware & { run: (req: Request) => Promise<void> }; |
There was a problem hiding this comment.
Hoping that in the future typescript will help us to avoid these awful signatures.
fedeci
force-pushed
the
one-of-error-messages
branch
from
540ead2
to
4b840c5
Compare
|
Merging this, we still have some time to update |
fedeci
commented
Sep 26, 2021
gustavohenke
pushed a commit
that referenced
this pull request
Dec 28, 2022
gustavohenke
pushed a commit
that referenced
this pull request
Dec 28, 2022
gustavohenke
pushed a commit
that referenced
this pull request
Jan 1, 2023
gustavohenke
pushed a commit
that referenced
this pull request
Jan 22, 2023
gustavohenke
pushed a commit
that referenced
this pull request
Mar 11, 2023
gustavohenke
pushed a commit
that referenced
this pull request
Mar 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This closes #956
We allow the user to choose between different error types:
grouped: new default behaviour that groups the errors based on the original branches.legacy: old behaviour that joins the errors from different branches togetherleastErroredOnly: returns only the group with less errorsTo-do list