Use readonly arrays for validator options #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like travis-ci.org has been halted, I'm trying to set us up on travis-ci.com now... 😕 |
|
(if the above doesn't work, we might have to use github actions...) |
|
I would directly go with GH actions that are better integrated. |
fedeci
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes validators options from
type[]toreadonly type[]- we don't do any mutation to them, so there's no need to require a mutable array.Example of the issue: https://www.typescriptlang.org/play?#code/MYewdgzgLgBAhgJwQLhggpnAJuANgT3jHwG0BdGAXhhIEYAaGAJkYGYyBuAKADMBXMMCgBLcDBwBlEAFt0UABbCwAcwAUSgA58oqOMXIBKGAG8Avl0ky5ilasQIDHIA
Fixes #1059
To-do list