docs: warn users about bad practice #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedeci
changed the title
fedeci
approved these changes
Sep 28, 2021
| ### Example: checking if password confirmation matches password | ||
|
|
||
| ```js | ||
| const { body } = require('express-validator'); | ||
|
|
||
| app.post( | ||
| '/user', | ||
| body('password').isLength({ min: 5 }), |
There was a problem hiding this comment.
This doesn't add that more layer of security because the custom validator will run even if the previous validators failed. We should probably change this behaviour in v7. (ref #990)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1087
https://express-validator.github.io/docs/custom-validators-sanitizers.html
The above documentation promotes a couple of bad practices that might affect the quality of the documentation.