Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: typescript example should use isEmpty method (guide/manually-running) #1276

Merged
merged 1 commit into from Feb 11, 2024

Conversation

DongSeonYoo
Copy link
Contributor

@DongSeonYoo DongSeonYoo commented Feb 1, 2024

Description

The example in the manual run guide in the official document does not work,

The errors property of the Result class in validation-result.ts is not accessible because it is a private property.

  • I thought about opening the errors property as public, but I didn't think it was a good way to encapsulate it

It states that the isEmpty method in the Result class has the following roles

1123

Therefore, you must use the isEmpty() method of the Result class to determine the presence or absence of an error

To-do list

  • I have added tests for what I changed.
  • This pull request is ready to merge.

Copy link
Member

@gustavohenke gustavohenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair call :)

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 576aafc on DongSeonYoo:master
into a260b24 on express-validator:master.

@gustavohenke gustavohenke merged commit 65319b6 into express-validator:master Feb 11, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants