Middleware Options #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! I've added you to the list of contributors, so feel free to merge this pull request and do according version bumps. I'm happy to publish a new package to npm once everything is ready! |
|
@ctavan did you bump the NPM version? It stil says version 4.1 on npmjs.org. Also, while you are in there, maybe bump the version of node-validator since I know that changed. |
|
@zero21xxx sorry, I didn't notice that you bumped the version. I just published the new version to npm. Please just mention me in the pull request when you bump the version next time so I don't miss out publishing it to npm. |
Closed
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored the middleware so it is now possible to pass options into the module. I did this for a very specific purpose; to be able to customize the errors being added into the error array, but now that it's here, more options can be used in the future.
I also moved the
checkParamfunction in one scoping level so it had access to the_optionsobject.Because this is a breaking change, I suggest the major release number is incremented by one.