Fix! Type Sanitizer #521
Closed
Fix! Type Sanitizer #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
gustavohenke
requested changes
Feb 12, 2018
There was a problem hiding this comment.
Hey, thanks for finding this out @Klemele!
We can't go that simple unfortunately as one defining custom sanitizers will mess with the interfaces of the filter API:
https://github.com/ctavan/express-validator/blob/df3f0067140e2d87b5f2c2e0a36db99f799904e1/test/type-definition.spec.ts#L13-L15
Also, can you please write a simple test here?
https://github.com/ctavan/express-validator/blob/df3f0067140e2d87b5f2c2e0a36db99f799904e1/test/type-definition.spec.ts#L42
|
Fixed it myself :) v5.0.2 has it. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Howdy guys,
Seems to be an issue with the last release and the typing from 'Sanitizer'.
This quick 'revert' seems to fix it ;).