Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typing for OptionalOptions #693

Merged
merged 3 commits into from
Mar 22, 2019
Merged

fix typing for OptionalOptions #693

merged 3 commits into from
Mar 22, 2019

Conversation

GitStorageOne
Copy link
Contributor

fix issue from #608

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2b0b2bb on GitStorageOne:master into 9a0b65a on express-validator:master.

@coveralls
Copy link

coveralls commented Mar 9, 2019 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 8f0289e on GitStorageOne:master into 9a0b65a on express-validator:master.

@GitStorageOne GitStorageOne mentioned this pull request Mar 19, 2019
Closed
gustavohenke
gustavohenke approved these changes Mar 22, 2019
View reviewed changes
Copy link
Member

@gustavohenke gustavohenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gustavohenke gustavohenke merged commit 3c0ff85 into express-validator:master Mar 22, 2019
@lock
Copy link

lock bot commented May 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gustavohenke gustavohenke gustavohenke approved these changes

@jeromecauchon jeromecauchon jeromecauchon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GitStorageOne @coveralls @gustavohenke @jeromecauchon