trim, ltrim... sanitize methods + fix Extending docs #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -42,7 +42,7 @@ var expressValidator = function(options) { | |||
| var methods = {}; | |||
|
|
|||
| Object.keys(validator).forEach(function(methodName) { | |||
| if (methodName.match(/^to/) || methodName in sanitizers) { | |||
| if (methodName.match(/^to/) || sanitizers.indexOf(methodName) != -1) { | |||
|
@bars3s Thanks a lot for your patch! I had two little comments and it would be great if you could address them. I'm happy to merge the Pullrequest as soon as the two comments are fixed. |
|
@ctavan I fixed it. |
|
Great! I'll merge it. Just another idea: It would of course be awesome to have some test coverage for this bug so it won't happen again in the future. I'd be super happy to merge such an addition to the test suite as well. |
ctavan
added a commit
that referenced
this pull request
Mar 17, 2014
trim, ltrim... sanitize methods + fix Extending docs
|
Published to npm as v2.1.1 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I hope they will be useful.