fix(oneOf): return Result when running imperatively

[fedeci]

Description

Fixes #995

Note that the ResultWithContext of a ValidationChain and oneOf is slightly different.

// body('foo').isString().run({ req: { foo: 'foo' } })
ResultWithContext {
  formatter: [Function (anonymous)],
  errors: [
    {
      value: 'foo',
      msg: 'Invalid value',
      param: 'foo',
      location: 'body'
    }
  ],
  context: Context {
    fields: [ 'foo' ],
    locations: [ 'body' ],
    stack: [ [StandardValidation] ],
    optional: false,
    message: undefined,
    _errors: [ [Object] ],
    dataMap: Map(1) { 'body:foo' => [Object] }
  }
}
// oneOf([body('foo').isString()]).run({ req: { foo: 'foo' } })
ResultWithContext {
  formatter: [Function (anonymous)],
  errors: [
    { msg: 'Invalid value(s)', param: '_error', nestedErrors: [Array] }
  ],
  context: Context {
    fields: [],
    locations: [],
    stack: [ [Object] ],
    optional: false,
    message: undefined,
    _errors: [ [Object] ],
    dataMap: Map(0) {}
  }
}

---

edit: no longer after e5e492a

To-do list

• I have added tests for what I changed.

• This pull request is ready to merge.

[coveralls]

Coverage remained the same at 100.0% when pulling e5e492a on fedeci:fix-one-of-imperatively into 735d76a on express-validator:master.

[gustavohenke]

Can we lie a bit and say that we only return a Result instead?

[fedeci]

Yes, it makes sense.

[bmax]

Looking forward to this thank you @fedeci @gustavohenke

[gustavohenke]

This is fixed on v6.11.0 🚀