-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature documentation #73
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the very good job! But why did you remove test_files,executables from zabbixapi.gempsec?
The zabbixapi gem does not include a bin/ directory, or any executables, so I removed that from the gemspec as it is an optional attribute |
Okay, I got it. Thank you for PR! 👍 |
This is a big one. Everything done here is backwards compatible code-wise, and all tests are passing in Travis CI - https://travis-ci.org/jrbeilke/zabbixapi/builds/223783663