Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Zabbix API v3.4 access (Closes: #81) #85

Merged
merged 1 commit into from Dec 16, 2018

Conversation

ottok
Copy link

@ottok ottok commented Mar 24, 2018

At least on our systems this version is now running in production and performing well.

@jrbeilke
Copy link
Collaborator

jrbeilke commented May 3, 2018

Need to update zabbixapi/spec/server.rb and it's high time we should drop support for 2.4 and 3.0 per the README (https://github.com/express42/zabbixapi#version-policy). I'll see what I can do.

it 'should be 2.4.x or 3.0.x or 3.2.x' do
  expect(zbx.server.version).to match(/(2\.4|3\.[02])\.\d+/)
end

@jrbeilke
Copy link
Collaborator

Looking over https://www.zabbix.com/life_cycle_and_release_policy and we may also want to consider changing the version policy for the gem to include the last two Zabbix versions along with the LTS release (ie. 3.2, 3.4, and 3.0 LTS).

@jrbeilke jrbeilke mentioned this pull request Jun 13, 2018
@paskal
Copy link

paskal commented Aug 12, 2018

From my experience working with Python library I can see what new API rarely have breaking changes: 3.2 library works with 3.4 and 4.0 as well without any changes. If your code raising proper errors in case API call returned an error, it seems safe not to check the version and assume the user will handle the problem.
It's a good practice not to hardcode supported versions list in my humble opinion.

@gdubicki
Copy link
Contributor

Let's keep the current policy of official support for last 2 versions, so 3.4 and 4.0 for now.

@gdubicki gdubicki merged commit 5608687 into express42:master Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants