Fix JSON strict parse error to match syntax errors

fixes #119
expressjs · Sep 7, 2015 · 06a5182 · 06a5182
1 parent 393fe31
commit 06a5182
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/HISTORY.md b/HISTORY.md
@@ -1,6 +1,7 @@
 unreleased
 ==========
 
+  * Fix JSON strict parse error to match syntax errors
   * Provide static `require` analysis in `urlencoded` parser
   * deps: qs@5.0.0
   * deps: type-is@~1.6.8

diff --git a/lib/types/json.js b/lib/types/json.js
@@ -80,7 +80,7 @@ function json(options) {
 
       if (first !== '{' && first !== '[') {
         debug('strict violation')
-        throw new Error('invalid json')
+        throw new SyntaxError('Unexpected token ' + first)
       }
     }
 

diff --git a/test/json.js b/test/json.js
@@ -62,8 +62,8 @@ describe('bodyParser.json()', function(){
     request(server)
     .post('/')
     .set('Content-Type', 'application/json')
-    .send('{"foo')
-    .expect(400, done);
+    .send('{:')
+    .expect(400, 'Unexpected token :', done);
   })
 
   it('should 400 when invalid content-length', function(done){
@@ -115,7 +115,7 @@ describe('bodyParser.json()', function(){
       .post('/')
       .set('Content-Type', 'application/json')
       .send('true')
-      .expect(400, 'invalid json', done)
+      .expect(400, 'Unexpected token t', done)
     })
 
     it('should allow leading whitespaces in JSON', function(done){
@@ -135,7 +135,7 @@ describe('bodyParser.json()', function(){
       .post('/')
       .set('Content-Type', 'application/json')
       .send('true')
-      .expect(400, done);
+      .expect(400, 'Unexpected token t', done);
     })
   })