Avoid throw for an acceptable situation
#250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When debugging and breaking on all exceptions, this one kept tripping because there is no charset parameter for my requests (for some reason) which seems reasonable. Prechecks for that case and avoids the throw, still returning undefined as it would have.
dougwilson
suggested changes
Jun 22, 2017
|
Sorry I didn't see your commit push earlier; looks like just a lint error failing the build, I can fix that & merge. |
|
P.S. I ported you change to the other parsers that were doing the same thing. |
dougwilson
pushed a commit
that referenced
this pull request
Sep 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When debugging and breaking on all exceptions, this one kept tripping because there is no charset parameter for my requests (for some reason) which seems reasonable. Prechecks for that case and avoids the throw, still returning undefined as it would have.