-
Notifications
You must be signed in to change notification settings - Fork 234
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
remove awful res.end/res.write noop patch
this removes the res.end/res.write to noop after request end patch, which is unnecessary and is really weird, because it will stop errors from triggerring that would normally trigger when this middleware is not being used. fixes #8
- Loading branch information
1 parent
73c50a9
commit 1412524
Showing
2 changed files
with
31 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1412524
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why these were added to the middleware in the first place
1412524
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the history of
connect
. It's because people provide patches and the maintainers sometimes just blindly accept things... :D1412524
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patch was provided for the same reason why someone might supply a patch to node.js to not get the
Can't send headers after send
error... because they were doing something in error, but just wanted to make the error not happen, lol.