Skip to content

Commit

Permalink
tests: entire test suite uses express 4.12.2
Browse files Browse the repository at this point in the history
  • Loading branch information
dougwilson committed Apr 18, 2015
1 parent 7cabc57 commit 8327163
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 16 deletions.
1 change: 1 addition & 0 deletions package.json
Expand Up @@ -17,6 +17,7 @@
"vary": "~1.0.0"
},
"devDependencies": {
"express": "~4.12.2",
"istanbul": "0.3.7",
"mocha": "2.2.1",
"supertest": "~0.15.0"
Expand Down
23 changes: 7 additions & 16 deletions test/compression.js
@@ -1,7 +1,7 @@
var assert = require('assert')
var bytes = require('bytes');
var crypto = require('crypto');
var http = require('http');
var express = require('express');
var request = require('supertest');

var compression = require('..');
Expand Down Expand Up @@ -458,7 +458,7 @@ describe('compression()', function(){
})

it('should return false on empty response', function (done) {
var server = http.createServer(function (req, res) {
var server = express().use(function (req, res) {
res.end(String(compression.filter(req, res)))
})

Expand All @@ -468,7 +468,7 @@ describe('compression()', function(){
})

it('should return true for "text/plain"', function (done) {
var server = http.createServer(function (req, res) {
var server = express().use(function (req, res) {
res.setHeader('Content-Type', 'text/plain')
res.end(String(compression.filter(req, res)))
})
Expand All @@ -479,7 +479,7 @@ describe('compression()', function(){
})

it('should return false for "application/x-bogus"', function (done) {
var server = http.createServer(function (req, res) {
var server = express().use(function (req, res) {
res.setHeader('Content-Type', 'application/x-bogus')
res.end(String(compression.filter(req, res)))
})
Expand Down Expand Up @@ -605,18 +605,9 @@ describe('compression()', function(){
})

function createServer(opts, fn) {
var _compression = compression(opts)
return http.createServer(function (req, res) {
_compression(req, res, function (err) {
if (err) {
res.statusCode = err.status || 500
res.end(err.message)
return;
}

fn(req, res)
})
})
return express()
.use(compression(opts))
.use(fn)
}

function shouldHaveBodyLength(length) {
Expand Down

0 comments on commit 8327163

Please sign in to comment.