Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when configured to reflect Access-Control-Request-Headers, should also use Vary: Access-Control-Request-Headers #61

Closed
jfirebaugh opened this issue Sep 18, 2015 · 4 comments
Assignees
Labels

Comments

@jfirebaugh
Copy link

When the middleware is configured to reflect the request value of Access-Control-Request-Headers in the response value of Access-Control-Allow-Headers (as it is in the default configuration), it should also include Vary: Access-Control-Request-Headers in the response. Without this header, it's possible to trigger a situation where a downstream cache responds to an OPTIONS request using a cached response from an OPTIONS request with a different Access-Control-Request-Headers value. This could potentially result in either a permissible OPTIONS request being refused, or a non-permissible request being allowed.

@troygoode troygoode added the bug label Sep 24, 2015
@troygoode
Copy link
Member

good catch @jfirebaugh - I'll try to address it soon

@bjoernwenzel-tommapps
Copy link

+1

@dougwilson dougwilson self-assigned this Mar 26, 2017
@dougwilson
Copy link
Contributor

I pushed a fix for the next version 👍

@troygoode
Copy link
Member

thanks for taking care of this @dougwilson – as well as some of the other recent work. I've bumped and published as 2.8.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants