Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo Fix #162

Closed
wants to merge 3 commits into from
Closed

Typo Fix #162

wants to merge 3 commits into from

Conversation

saravyas
Copy link

This PR includes

  1. optionsSuccessStatus name change into optionSuccessStatus because it deal with single option

@dougwilson
Copy link
Contributor

Thanks! But this is (1) a major breaking change and (2) it is correct, as "Options" refers to the method being the name OPTIONS, as in "optionsSuccessStatus" is the success status for the OPTIONS method.

@dougwilson dougwilson closed this Nov 13, 2018
@dougwilson dougwilson self-assigned this Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dougwilson dougwilson

Labels
invalid pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saravyas @dougwilson