Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add warning about regexp global flag usage #225

Closed
wants to merge 1 commit into from

Conversation

abhijit-hota
Copy link

See #220

@dougwilson
Copy link
Contributor

Thank, but this allies to any JavaScript API that accepts a RegExp object and is not specific to this module.

@abhijit-hota
Copy link
Author

@dougwilson I agree.

But this single line of documentation could have saved me (and most probably 5 others, based on the +1s on the issue) a lot of time and I would have never opened the issue in the first place.

I agree it applies to any JavaScript API but then again, it is just my opinion.

Of course, in the end it's your choice.

@dougwilson
Copy link
Contributor

Hi @abhijit-hota I definately understand, but typically there is a base-level of knowledge required to read the docs of anything out there. We have to draw the line somewhere to keep the docs from getting out of control, as otherwise the docs would end up just being overwhelmed with notes about how JavaScript works throughout it. Please don't take this response as saying you are unfamiliar with JavaScript, only just stating where we draw the line for our docs: if it is about how JavaScript works (as is the case with this PR) then we don't add it to the docs. If it is something specific to how this module works, then of course we would add it.

@abhijit-hota
Copy link
Author

@dougwilson I understand. Thank you for the response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants