Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

self-nomination for express committer #113

Closed
gireeshpunathil opened this issue Apr 2, 2020 · 3 comments
Closed

self-nomination for express committer #113

gireeshpunathil opened this issue Apr 2, 2020 · 3 comments

Comments

@gireeshpunathil
Copy link

Non-trivial contributions:

@dougwilson
Copy link
Contributor

Thanks @gireeshpunathil for opening this issue. I hope that in our meeting the discussion around this and the expectations for the next steps you need to take are clear on what you need to continue to do in order to be elevated to a committer 👍

You have done a lot of work, and we are very thankful, but I do not believe there have been non trivial contributions at this time. A good example is on your recent PR in which it took quite some time in order to make a functional PR and it seems in general there is a lack of understanding of the underlying mechanisms of the documented commit process itself.

I think you are on the right path and we will reconsider as we see non trival contributions coming that do not require hand holding in order to get committer rights.

If you disagree, please expand on here. I did try and look though the list you provided, but there are quite a few in thee (like expressjs/session#737) where it is unclear on what your contribution was (let alone it being non trival). You can also expand on what your plan is to do with the elevated status.

@gireeshpunathil
Copy link
Author

@dougwilson - thanks for the feedback. Just expanding on a couple:

where it is unclear on what your contribution was

expressjs/session#737 : came in 10 days ago and not tagged with any priority, so definitely not planning to look at it at the moment. After the GA, I have a mind to re-prioritize my work and start focussing on session repo

You can also expand on what your plan is to do with the elevated status.

  • work with peers / TC to identity priorities for the project
  • work with peers / TC to identify specific repos to focus
  • start picking up loads where existing bandwidth is scarce
  • identify improvement areas and come up with actionable plans
  • take part, and feel pride in the success of express!

@IamLizu
Copy link
Member

IamLizu commented Aug 21, 2024

I was reading some old threads and stumbled upon this. Closing in reference with #227 (comment).

@IamLizu IamLizu closed this as not planned Won't fix, can't repro, duplicate, stale Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants