Error handling with domains doesn't works well

[al6x]

try/catch statement in the next interferes with error handling via domains.

Try this example, one error will be catch another will be not. It's not a critical issue, there are ways to workaround it, but would be nice if it just worked out of the box.

var Domain  = require('domain')
var express = require('express')

var app = express.createServer()

app.use(function(req, res, next){
  var domain = Domain.create()
  domain.on('error', function(err){
    res.send("Catched " + err.message)
  })
  domain.run(next)  
})

app.get('/failed-to-catch', function(req, res){
  throw new Error('hello there!')
})

app.get('/catched', function(req, res){
  process.nextTick(function(){throw new Error('hello there!')})
})

app.listen(3000)

[tj]

definitely dont want to remove existing error handling just to let things bubble up for domains, at least until they're proven, closing for now

[emostar]

I think express can support domains more naturally by having the router call the functions inside a process.nextTick.

This is a one line change like this:

    if (fn.length < 4) return process.nextTick(function() {fn(req, res, callbacks)});

Would there be any undesired side effects from doing that?