Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attachment or download filename should have a max length - else some browsers fail #3329

Closed
kapouer opened this issue Jun 7, 2017 · 3 comments

Comments

@kapouer
Copy link
Contributor

kapouer commented Jun 7, 2017

Hi,

when giving a filename long enough (254 chars long, for example), some browsers fail the download with an error.
Express should warn, or even truncate the filename (but keep the file extensions).
Using express@4.15.3:

  • epiphany 3.24, chromium 58 fail
  • firefox 45.9 does not fail
@dougwilson
Copy link
Contributor

Is there a specification on what the max length is or at least somewhere to determine what the max lengths for all the possible clients will accept are?

@kapouer
Copy link
Contributor Author

kapouer commented Jul 9, 2017

That is still to be found. I wasn't able to find any kind of limitation explicitely coded into webkit trunk.

@dougwilson
Copy link
Contributor

It doesn't sound like there is anything actionable here. If you think otherwise, please let me know what steps you would like to see taken (perhaps even a pull request)! If this is actually a violation of a spec or even just understanding what limits the clients have, that would be great to have, but limiting it for two clients out of many doesn't seem like a limit that should be built in Express directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants