Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It a good idea add the helmet lib how default in the express? #3437

Closed
MichelAraujo opened this issue Sep 29, 2017 · 8 comments
Closed

It a good idea add the helmet lib how default in the express? #3437

MichelAraujo opened this issue Sep 29, 2017 · 8 comments
Labels

Comments

@MichelAraujo
Copy link

The helmet is a good lib that completes the express security, would not be better add per default in express?

@dougwilson
Copy link
Contributor

Express doesn't really include anything out of the box, besides the absolute essentials. Express 3.x used to include a lot, but it got out-of-hand, especially when those modules didn't match the same support policies of Express itself.

Now, I'm not saying this applies to helmet, I would have to talk with the maintainer(s) to better understand, ideally they should be willing to support this as well. Just wanted to give some background, especially around the goal of Express 4 was specifically to not include middlewares with Express.

@MichelAraujo
Copy link
Author

If express goal is not include middlewares, include helmet sounds unnecessary, but would be nice to add helmet features on express core.

@dougwilson
Copy link
Contributor

Which features? What would it take to add those features? We could maybe do so, but need to better understand what the ask is here.

@frankis
Copy link

frankis commented Oct 7, 2017

Security should be a concept handled at design / architecture stage of an App / Service and not a package being added to core - please don‘t even consider adding it to core.

@wurde
Copy link

wurde commented Oct 10, 2017

Please keep express minimalistic and free of opinionated middleware. I especially don’t like how helmet was written. The core concepts in helmet are good, but most of it is setting the correct response headers. Trivial stuff to rewrite.

If OP wants to include certain middleware into their app then encourage them to write their own opinionated app framwework on top of express.

@PazzaVlad
Copy link

Absolutely agree with previous comment! Please, don't pollute codebase with external plugins.

@drmnk
Copy link

drmnk commented Nov 7, 2017

Definitely we don't need a big, bloated with 'middleware of someone choice' Express. Keep it minimal.

And leave links to all good middlewares in "best practices' (just like it is now). People will find it, learn it and use if them need it.

@knoxcard
Copy link

knoxcard commented Jan 1, 2018

Another great reason to not include Helmet or other plugins is FOCUS. More developers will stay FOCUSED on the other repos and improve that code and that concept. Otherwise, Express becomes a webserver/security project when it should focus on being a webserver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants