Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cookie-signature dependency has timing vulnerability #3583

Closed
drewjenkins opened this issue Mar 6, 2018 · 6 comments
Closed

cookie-signature dependency has timing vulnerability #3583

drewjenkins opened this issue Mar 6, 2018 · 6 comments

Comments

@drewjenkins
Copy link

See https://snyk.io/vuln/npm:cookie-signature:20180111 for details.

To resolve, upgrade the cookie-parser dependency to 1.1.0 or above

@dougwilson
Copy link
Contributor

We cannot upgrade because Node.js 6 is required to upgrade.

@dougwilson
Copy link
Contributor

See discussion and my rejected PR in tj/node-cookie-signature#25

@dougwilson
Copy link
Contributor

The author of cookie-signature asserts that Snyk is wrong and prior versions are not vulunerable. We are kinda stuck...

@dougwilson
Copy link
Contributor

I created tj/node-cookie-signature#27 to determine more from that upstream dependency.

Security issues need to be reported per our policy in https://github.com/expressjs/express/blob/master/Security.md in the future.

@expressjs expressjs locked and limited conversation to collaborators Mar 6, 2018
@dougwilson
Copy link
Contributor

FYI the author of cookie-signature is looking to contact Snyk to remove the incorrect report: tj/node-cookie-signature#27 (comment)

@dougwilson
Copy link
Contributor

The Snyk report was incorrect and has been removed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants