Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking] Update to router@2.0.0 #4229

Closed
jonchurch opened this issue Apr 1, 2020 · 3 comments
Closed

[Tracking] Update to router@2.0.0 #4229

jonchurch opened this issue Apr 1, 2020 · 3 comments

Comments

@jonchurch
Copy link
Member

jonchurch commented Apr 1, 2020

I believe for v5 we are updating router. This is just a tracking issue for updating the dep in express. Once pillarjs/router#60 is published, we can open a PR to update the router version.

I'm not sure if there's a PR somewhere already to update the v5 docs to be in line with router@2 changes.

@jonchurch jonchurch added this to the 5.0 milestone Apr 1, 2020
@dougwilson
Copy link
Contributor

Thank @jonchurch ! Can you clarify what, specifically this issue is tracking? For example, if this is a specific change, can it just be a PR directly? If it is to track landing the router@2 as a dependency on express@5, that has already happened, so it's closed 🎉 . If it's about documentation, that would belong on the expressjs.com issue tracker.

@dougwilson
Copy link
Contributor

Duplicate of #2411 unless there is something else here I'm missing...

@dougwilson dougwilson removed this from the 5.0 milestone Apr 1, 2020
@jonchurch
Copy link
Member Author

You're right this was a duplicate 👍 I didn't search well enough, ty for tying this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants