Request.accepts documentation comment issue.

[Bunpasi]

Hello.

Small thing in the documentation comments of 'Request.accepts' in 'index.d.ts'. It says to return 'undefined' instead of 'false'.

Kind regards,

[krzysdz]

May I know which documentation are you referring to? The official documentation says:

The method returns the best match, or if none of the specified content types is acceptable, returns false ...

However, Express does not contain TypeScript definition files. The @types/express package is maintained by the DefinitelyTyped project, but the declaration of Request.accepts() there does not contain undefined as the return type in any overload.

[Bunpasi]

express-serve-static-core/index.d.ts line 398.

[krzysdz]

I've opened a PR to fix it: DefinitelyTyped/DefinitelyTyped#68381

[krzysdz]

New version of @types/express-serve-static-core (4.17.43) was released with the documentation fix.

[Bunpasi]

Great! I heard you guys had some issues with contributions lately. I know this wasn't the most important thing, but I hope it will be helpful to someone.