Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The npm latest version of express is 5.0.0-beta.2 !!! #5558

Closed
drobnikj opened this issue Mar 21, 2024 · 10 comments
Closed

The npm latest version of express is 5.0.0-beta.2 !!! #5558

drobnikj opened this issue Mar 21, 2024 · 10 comments
Assignees
Labels

Comments

@drobnikj
Copy link

Can you double-check that it is on purpose?

I cannot see any notes about this major release in the change log.
This can potentially break a lot of stuff without proper release notes and migration guide.

Did I miss anything?

image

@UlisesGascon
Copy link
Member

I am working on it, thanks for the ping @drobnikj

@UlisesGascon UlisesGascon self-assigned this Mar 21, 2024
@UlisesGascon
Copy link
Member

I close the issue as this is now fixed. Thanks for the CLI tricks @jonchurch

Screenshot from 2024-03-21 09-47-00
Screenshot from 2024-03-21 09-47-21

@wesleytodd
Copy link
Member

wesleytodd commented Mar 21, 2024

Was not on purpose. Just an oversight in a manual process being done for the first time in my part.

@fire015
Copy link

fire015 commented Mar 25, 2024

This is still visible on NPM fyi @wesleytodd @UlisesGascon

@wesleytodd
Copy link
Member

Screenshot 2024-03-25 at 9 23 42 AM

Not for me.

@fire015
Copy link

fire015 commented Mar 25, 2024

@wesleytodd Sorry what I meant was, is beta.2 supposed to be showing up at all in NPM considering there is no tag/release or changelog about it in this repo?

@wesleytodd
Copy link
Member

is beta.2 supposed to be showing up at all in NPM considering there is no tag/release or changelog about it in this repo?

Yes it was intentional to publish, just not without --tag=next. I added the releases on GH now (including the new one just published). Sorry for the confusion.

@fire015
Copy link

fire015 commented Mar 25, 2024

Thanks, it just looked suspicious (you hear about NPM packages been hacked all the time) 👍

@wesleytodd
Copy link
Member

Yep! Thanks for checking!

@jonchurch
Copy link
Member

Yep thanks for noticing and reporting @fire015

The impact this would have had during the couple of hours that latest pointed to v5 was that folks who npm i express would have gotten v5 beta instead of v4.

It also likely triggered some "hey there's a new major available" notices to folks.

because NPM lets you change where latest points without a republish, we just fixed it once we noticed by doing a
npm dist-tag add express@<version> latest to point to the correct v4 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants