clean code for switch condition

[geraldsamosir]

i want to ask about this code

that write with logic

  switch (lc) {
    case 'referer':
    case 'referrer':
      return this.headers.referrer
        || this.headers.referer;
    default:
      return this.headers[lc];
  }
};

is that more readable and cleaner when we write that with

  switch (lc) {
    case 'referer':
      return  this.headers.referer;
    case 'referrer':
      return this.headers.referrer;
    default:
      return this.headers[lc];
  }
};

i just giving my opinion as express js users

[wesleytodd]

Thanks for your opinion. This code has been there for a while and I don't know if folks shared style opinions back when it was written. But we do not accept style only PRs, so likely there is not much we are going to change for this.

[LinusU]

Just giving some more context here: the proposed change would no longer do the same thing. The point of the code is to treat both the referrer and referer header as the same. In your updated version only the one asked for would be given, making the entire switch case functionally equivalent to just return this.headers[lc].

Here is some background on why referrer is misspelled in the header name: https://en.wikipedia.org/wiki/HTTP_referer#Etymology