Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import changes to fix code blocks, etc. #597

Closed
crandmck opened this issue Mar 7, 2016 · 3 comments
Closed

Import changes to fix code blocks, etc. #597

crandmck opened this issue Mar 7, 2016 · 3 comments

Comments

@crandmck
Copy link
Member

crandmck commented Mar 7, 2016

Import the changes made in https://github.com/expressjs/express-api-docs/pull/3. This allows us to use backticks for code blocks, and some other improvements.

@crandmck
Copy link
Member Author

crandmck commented Apr 19, 2016

This includes the changes above and modiying all the code blocks to use backticks. I also added the Gemfile, updated config.yml as in https://github.com/expressjs/express-api-docs/pull/3, as well as adding to it the line

hard_wrap: false

which seems to be required to make text wrap properly.

However, in this branch there is an issue with the 4.x API doc page (http://localhost:4000/en/4x/api.html when running locally). It seems that prism.js is throwing an error, which really screws up the layout for that page (only).... but I haven't been able to get to the bottom of it.

@hacksparrow Can you please have a look and see if you can sort out what's going on?

Also, I would appreciate any other eyes. Merging this branch is going to be a huge PR because it touches almost every file.

@crandmck
Copy link
Member Author

I figured out the problem with the 4.x API page and committed fix to the branch.

@crandmck
Copy link
Member Author

Fixed with #628 for English content.
I did not do the same for translated content, so the PR wasn't as large as I originally thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant