Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect to https #955

Open
Munter opened this issue Jul 25, 2018 · 11 comments
Open

Redirect to https #955

Munter opened this issue Jul 25, 2018 · 11 comments

Comments

@Munter
Copy link

Munter commented Jul 25, 2018

The current documentation responds to http: requests. It would improve security if it would redirect to the https: equivalent instead

@crandmck
Copy link
Member

crandmck commented Aug 14, 2018

So GitHub started supporting this in May (cf. https://blog.github.com/2018-05-01-github-pages-custom-domains-https/).

But it looks like we can't do this until we update the DNS record (per https://help.github.com/articles/troubleshooting-custom-domains/#https-errors). However, IBM still controls this AFAIK.

@rmg Can you make this change?

@dougwilson
Copy link
Contributor

Yea. The dns is currently a cloudflare account. We can enable https only through there too. A while back there concern about https only though cloudflare was that if we needed to go back to github direct it would break https links.

Now that github directly supports https there is no concern, so even just flipping on https only in cloudflare is doable, whichever is easier.

@annevk
Copy link

annevk commented Feb 18, 2019

Any update on this?

@dougwilson
Copy link
Contributor

Rand, do you know who has access to the cloudflare account? I think it has all been transferred to node.js foundation last I remember.

@Knighton910
Copy link
Contributor

Im glad you guys are talking about this issue, If you need any help let me know.

@crandmck
Copy link
Member

crandmck commented Mar 15, 2019

This was discussed some time ago: expressjs/discussions#68 (comment) but I think someone in Node Foundation needs to do something.... Maybe we can get their attention? @mikeal

@Knighton910
Copy link
Contributor

Why are you even here then Rand (haha). Just Kidding, i am grateful for all you did do for the express Project. Anyway hopefully we will get it sorted out soon.

@ryhinchey
Copy link
Contributor

This issue is a duplicate of #695. Would be great to get some help on this!

@jcubic
Copy link

jcubic commented Aug 23, 2023

I've just noticed that HTTPS is working but there is a lack of redirect. Google Chrome opens HTTPS by default but if you click on the link from DuckDuckGo you get the website over HTTP:

https://duckduckgo.com/?q=express.js&ia=web

@jcubic
Copy link

jcubic commented Aug 23, 2023

Do you have the Enforce HTTPS option enabled for this repo?

https://docs.github.com/en/pages/getting-started-with-github-pages/securing-your-github-pages-site-with-https

If yes and it doesn't work, I would just contact GitHub support. No contributor can help you with this. Since settings require Admin rights to the repository.

@dougwilson
Copy link
Contributor

Hi @jcubic girhub shows that setting is unavailable because there is a Cloudfront endpoint in front. This issue and other is us teying to get in contact with the appropriate folks to change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants