Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hogan (hjs) option #77

Closed
cmawhorter opened this issue May 11, 2015 · 2 comments
Closed

Remove hogan (hjs) option #77

cmawhorter opened this issue May 11, 2015 · 2 comments
Assignees
@dougwilson
Labels
discuss

Comments

@cmawhorter
Copy link

hjs seems to be effectively dead: nullfirm/hjs#2 (comment)

I have no alternative to suggest but the documentation still references express 3.0 and it could be confusing once 3.0 is deprecated.
@dougwilson
Copy link
Contributor

Sounds fine. We can remove in the next major version (5) unless anyone objects.

@dougwilson dougwilson self-assigned this May 11, 2015
@dougwilson
Copy link
Contributor

dougwilson commented Oct 21, 2016 •
edited

So in all this time, no one has ever really chimed in on this, and we have a test that continues to pass with the current hjs and Express 4.x, so unless there is some really good reason, I don't see any real reason for the removal unless it stops working with Express (and ideally our tests should tell us when that happens). ¯\_(ツ)_/¯

cwonrails pushed a commit to cwonrails/generator that referenced this issue Apr 29, 2018
@johno
Merge pull request expressjs#77 from jessestuart/jesse/add_line_heigh…
089aa17 
…t_options

[feat] Add module to configure `line-height`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dougwilson dougwilson

Labels
discuss
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dougwilson @cmawhorter