mocking date for a test to ensure pad2 runs with single digit dates #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryhinchey
commented
Feb 27, 2020
test/morgan.js
Outdated
Comment on lines
215
to
217
| var GlobalDate = global.Date | ||
|
|
||
| global.Date = function () { return new GlobalDate('2020-02-27') } |
There was a problem hiding this comment.
I'm not proud of this but sinon did not play nice with node 0.8 or 0.10 https://travis-ci.org/expressjs/morgan/builds/655979079
ryhinchey
force-pushed
the
pad2-single-digit-dates
branch
from
2695456
to
4cd206a
Compare
ryhinchey
force-pushed
the
pad2-single-digit-dates
branch
from
4cd206a
to
e3c1b84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test to always make sure
pad2is covered. When running tests, if every value passed topad2is two digits (which depends on the time the tests are run), a drop in coverage can happen.To mock the date I added
sinon@2.0.0.as a dependency.2.0.0was used as it was an older version that I hoped would work in older versions of node