Supporting PUT requests?

[ItalyPaleAle]

In multer/Express 4 support for PUT requests has been removed. Multer should parse PUT requests as well as POST ones.

[nfroidure]

👍

[gplancke]

👍

[hacksparrow]

Thanks for bringing it to notice and fixing it guys!

[ItalyPaleAle]

Thanks for the patch, but I'm not sure this is completely fixed!
Indeed, this keeps supporting only multipart/form-data encoded requests. PUT requests instead often have in the body just te contents!

[hacksparrow]

I had originally intended Multer to handle ONLY multipart POST data, as there was no middleware to handle this specific data. Issue #17 also needs to be addressed. It's time to revise Multer.

[ItalyPaleAle]

Now that Express 4 is out, I think you should consider that. Issue #17 is one thing, but I would also add support for XML and JSON requests too, at this point.
Would it be ok with you if I investigated a patch? I may have some spare time mid next week, but no promises at all.

[hacksparrow]

Feel free to work on a patch. However, the current most important task is
writing tests, it will help add new features and bug fixes without having
to fear regression issues. I am a little occupied, so not able to do much.

On Mon, May 5, 2014 at 3:48 AM, Alessandro notifications@github.com wrote:

Now that Express 4 is out, I think you should consider that. Issue #17https://github.com/expressjs/multer/issues/17is one thing, but I would also add support for XML and JSON requests too,
at this point.
Would it be ok with you if I investigated a patch? I may have some spare
time mid next week, but no promises at all.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/9#issuecomment-42147430
.

[hacksparrow]

@EgoAleSum did you get a chance to work on it?

[ItalyPaleAle]

Not yet, sorry

[hacksparrow]

No problem.

[hacksparrow]

It does now.