Close write stream on connection error (FD leak on incomplete uploads) #971
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen a large number of open FD's when using express with multer.
After investing, we have found the issue to be aborted uploads.
It seems the upload FD is not being closed if the client aborts the request mid-way.
How To Reproduce
From the readme (adapted to a single field):
Using whichever client, upload a file and abort it during transit:
Finally using lsof on the node process, you should see a FD leaked to the
uploads
directoryRelated(?)