New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add contributing guide #4
Conversation
This is ready for review (cc: @expressjs/express-tc) |
e17f733
to
abea1ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than my two very small nitpick's LGTM!
I second the two comments from @wesleytodd |
Co-authored-by: Wes Todd <wes@wesleytodd.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I will merge the PR as the suggestions were addressed 馃憤 |
This is an initial version, feel free to add your feedback 馃憤