Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add contributing guide #4

Merged
merged 3 commits into from Mar 10, 2024
Merged

docs: add contributing guide #4

merged 3 commits into from Mar 10, 2024

Conversation

UlisesGascon
Copy link
Member

@UlisesGascon UlisesGascon commented Mar 4, 2024

This is an initial version, feel free to add your feedback 馃憤

@UlisesGascon UlisesGascon marked this pull request as ready for review March 4, 2024 17:46
@UlisesGascon UlisesGascon requested review from a team March 7, 2024 13:51
@UlisesGascon
Copy link
Member Author

This is ready for review (cc: @expressjs/express-tc)

Contributing.md Outdated Show resolved Hide resolved
Contributing.md Outdated Show resolved Hide resolved
Copy link
Member

@inigomarquinez inigomarquinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my two very small nitpick's LGTM!

Contributing.md Outdated Show resolved Hide resolved
Contributing.md Outdated Show resolved Hide resolved
@crandmck
Copy link
Member

crandmck commented Mar 7, 2024

I second the two comments from @wesleytodd
Otherwise, LGTM

UlisesGascon and others added 2 commits March 7, 2024 20:41
Copy link
Member

@inigomarquinez inigomarquinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@UlisesGascon
Copy link
Member Author

I will merge the PR as the suggestions were addressed 馃憤

@UlisesGascon UlisesGascon merged commit b981707 into main Mar 10, 2024
@UlisesGascon UlisesGascon deleted the docs/collaboration branch March 10, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants