Use etag to generate ETag header

expressjs · Aug 25, 2014 · b251cb9 · b251cb9
1 parent e597da9
commit b251cb9
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/HISTORY.md b/HISTORY.md
@@ -1,3 +1,8 @@
+unreleased
+==========
+
+  * Use `etag` to generate `ETag` header
+
 2.0.1 / 2014-06-05
 ==================
 

diff --git a/index.js b/index.js
@@ -10,7 +10,7 @@
  * Module dependencies.
  */
 
-var crypto = require('crypto');
+var etag = require('etag');
 var fresh = require('fresh');
 var fs = require('fs');
 var path = require('path');
@@ -91,14 +91,6 @@ function createIsDirError(path) {
   return error;
 }
 
-function etag(buf){
-  var hash = crypto
-    .createHash('md5')
-    .update(buf)
-    .digest('base64');
-  return '"' + hash + '"';
-}
-
 function send(req, res, icon){
   var _fresh = fresh(req.headers, icon.headers);
   var buf = _fresh ? '' : icon.body;

diff --git a/package.json b/package.json
@@ -11,6 +11,7 @@
   ],
   "repository": "expressjs/serve-favicon",
   "dependencies": {
+    "etag": "~1.2.0",
     "fresh": "0.2.2"
   },
   "devDependencies": {