Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG #8

Closed
julesmoretti opened this issue Jul 13, 2014 · 10 comments
Closed

SVG #8

julesmoretti opened this issue Jul 13, 2014 · 10 comments

Comments

@julesmoretti
Copy link

Would it be possible to support svg elements to retain a crisp definition?

Either way thank you! It is very cool.

@dougwilson
Copy link
Contributor

Sure, though can you provide more information on how SVG works for the favicons?

  1. Are they still served under /favicon.ico?
  2. What MIME type do they usually use?
  3. Which browsers support this?

@defunctzombie
Copy link
Contributor

I don't think anyone supports this. Crisp definition on retina requires a special retina ready favicon (actually two favicons in one file). This library already supports that use case.

@dougwilson
Copy link
Contributor

Besides that, this library is just for the /favicon.ico-style implicit icons; the SVG stuff doesn't even do that and requires the used to add HTML anyway, so it seems to be out of the scope of this library.

@Fishrock123
Copy link
Contributor

There isn't enough support for favicon svgs for it to be worthwhile. it is better to pack multiple resolutions into your .ico.

Tools for this can be difficult to find, however.

A best case ICO has 16, 24, 32, 48px and possibly a 64 px or bigger version.

@julesmoretti
Copy link
Author

Thank you for your consideration. I appreciate the legacy of using ICO, though I would argue that packing multiple pixel heavy ico (in the case of Fishrock123 - 5 different version), is not as clean as vector information svg that can take on any scale due to its vector base.

As a UX designer, it is far cleaner to use vector files then having to fudge with pixel to try to make things ready... plus if not now, it is going to happen soon enough.

Just a thought...

@dougwilson
Copy link
Contributor

@julesmoretti I think you mis-understand what this module even does: this module only serves the requests for the standard /favicon.ico URL. There is no standard for a SVG file, so there is nothing for us to support in this library. To use a SVG favicon, you have to add the path to it in your HTML, and at that very point it's outside the scope of this module.

@dougwilson
Copy link
Contributor

Wikipedia explains this module pretty OK. If you go to https://en.wikipedia.org/wiki/Favicon#How_to_use you can see the many ways to specify a favicon. The "favicon.ico located in the website's root" is the only purpose of this module.

@julesmoretti
Copy link
Author

@dougwilson ok cool sorry for the bother.

@Fishrock123
Copy link
Contributor

I'm really not sure any browsers even accept svg favicons at the current time..

@dougwilson
Copy link
Contributor

I think there may be a couple, but since you have to use a <link> tag, you can just serve them up with all your other files.

@expressjs expressjs locked and limited conversation to collaborators Jul 28, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants