-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVG #8
Comments
Sure, though can you provide more information on how SVG works for the favicons?
|
I don't think anyone supports this. Crisp definition on retina requires a special retina ready favicon (actually two favicons in one file). This library already supports that use case. |
Besides that, this library is just for the |
There isn't enough support for favicon svgs for it to be worthwhile. it is better to pack multiple resolutions into your Tools for this can be difficult to find, however. A best case ICO has 16, 24, 32, 48px and possibly a 64 px or bigger version. |
Thank you for your consideration. I appreciate the legacy of using ICO, though I would argue that packing multiple pixel heavy ico (in the case of Fishrock123 - 5 different version), is not as clean as vector information svg that can take on any scale due to its vector base. As a UX designer, it is far cleaner to use vector files then having to fudge with pixel to try to make things ready... plus if not now, it is going to happen soon enough. Just a thought... |
@julesmoretti I think you mis-understand what this module even does: this module only serves the requests for the standard |
Wikipedia explains this module pretty OK. If you go to https://en.wikipedia.org/wiki/Favicon#How_to_use you can see the many ways to specify a favicon. The "favicon.ico located in the website's root" is the only purpose of this module. |
@dougwilson ok cool sorry for the bother. |
I'm really not sure any browsers even accept svg favicons at the current time.. |
I think there may be a couple, but since you have to use a |
Would it be possible to support svg elements to retain a crisp definition?
Either way thank you! It is very cool.
The text was updated successfully, but these errors were encountered: