feat(sort): Add sort option - micah/35/sort #75
Conversation
|
yea, done. thought it might be related to the linting problem, looks like it's not now. thanks for watching this one 😄 and also, thanks for introducing to me https://github.com/eslint/eslint-plugin-markdown had never noticed this particular eslint plugin before |
|
🎉 hooray, tests are green |
|
Nice! I'm pretty much about to go to sleep for work in the morning and will take a look as soon as I can and get this feature landed 😴 |
|
@dougwilson is there anything I can do to improve this PR? |
|
I will take a look when I get to a computer. |
|
Are there any plans to merge this PR? Easily sorting by date would be very beneficial. |
|
know that @dougwilson was busy back in August, but maybe, just maybe there's a bit more reviewer bandwidth here in the new year 😄 |
|
@dougwilson i could use this too. any chance on a merge? |
|
Ring ring? Sorely missing feature! |
|
@dougwilson Click the button ;) |
|
The sort option should apply to all the response types not just the html one. |
micahstubbs
force-pushed
the
micah/35/sort
branch
from
36db6f2
to
d6677e7
Compare
|
looks like the Appveyor node 1.8 env flaked out on us 😢 let's see if I can trigger a second test run 🤔 https://ci.appveyor.com/project/dougwilson/serve-index/builds/26065525 |
|
🎉 tests are green. should be ready for another look @dougwilson 😄 |
A small PR that adds user-configurable sort for html outputs
Fix #35
a fork of @thaiat's nice PR #41 with a small amount of additional work to get the Travis CI and Appveyor tests to pass.