Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump cookie and safe buffer #672

Merged
merged 1 commit into from
Aug 16, 2019
Merged

bump cookie and safe buffer #672

merged 1 commit into from
Aug 16, 2019

Conversation

knoxcard
Copy link
Contributor

bump cookie and safe buffer

dougwilson
dougwilson suggested changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@dougwilson dougwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you add history entry as well and split this into two prs? You can use the previous dependency bump commits for examples of how to structure the hiatory file :)

@dougwilson
Copy link
Contributor

Another user created a PR for the cookie update (#674). I will pull that out of this one and leave it just as the safe-buffer change 👍

@dougwilson dougwilson self-assigned this Aug 16, 2019
@dougwilson dougwilson merged commit 10607bd into expressjs:master Aug 16, 2019
@knoxcard knoxcard deleted the patch-2 branch September 29, 2019 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougwilson dougwilson dougwilson approved these changes

Assignees

@dougwilson dougwilson

Labels
deps pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@knoxcard @dougwilson