Fix res.end patch to always commit headers #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After dropping this in-place and rerunning my existing code that caused me to discover this, it seems to be working exactly as I would expect! Thank you very much for this prompt fix! |
|
No problem at all, thanks for reporting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a missing command to commit the progressive headers within
res.endbefore attempting to read them. This has the standard side-effect of ensuring a second call tores.endwill fail with a headers already set error. This is the same behavior other modules likecompressiondoes to get the headers set, same as the internal Node.js code ofres.end.Fixes #766