New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LIT-134 Initial implementation of Path MTU Discovery #128
Conversation
b3c8916
to
2d06201
Compare
19b0db0
to
6f0f8dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Tom, from what I can tell the code logic is fine. I just have some suggestions and small nits. I've also convinced myself that the state machine handles delayed acks coming back properly, but it would be good to have a test case for that.
6a2f275
to
0ba2dd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Initial implementation of Path MTU Discovery, based on RFC 8899.
Motivation and Context
The Maximum Transmission Unit (MTU) is the largest amount of data that can be transmitted in a single packet on a network. It is a parameter that is determined by the underlying network technology, and can be configured on network devices (such as routers and switches).
The MTU is important because it determines the maximum size of data that can be transmitted across a network without fragmentation. If a packet is larger than the MTU, it is fragmented into smaller packets to be transmitted across the network, and then reassembled at the receiver. Fragmentation can result in additional processing overhead and increased network traffic, which can impact performance.
The goal of this feature is to allow Lightway seamlessly adapt the Path MTU to any network and reduce the connected-but-cannot-browse issues.
How Has This Been Tested?
Unit and integration tested.
Types of changes
Checklist:
main