Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVPN-935: add WolfSSL TLS1.3 Middlebox Compatibility #169

Merged
merged 1 commit into from
May 27, 2024

Conversation

xv-geoff-hb
Copy link
Collaborator

This PR adds the TLS 1.3 Middlebox Compatibility to WolfSSL (RFC8446 Appendix D.4), which may help for some traffic profiles on some networks.

Description

  • Add -DWOLFSSL_TLS13_MIDDLEBOX_COMPAT flag WolfSSL for all device types (no D prefix for Windows).

Motivation and Context

Enabling TLS 1.3 Middlebox Compatibility Mode has been documented to help some TLS connections more reliably traverse some networks, as described in the RFC linked above, and elsewhere on the Internet.

How Has This Been Tested?

Build Lightway and observe the TLS handshake contains elements described in RFC8446 Appendix D.4, linked above.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All active GitHub checks are passing
  • The correct base branch is being used, if not main

@xv-geoff-hb xv-geoff-hb requested a review from a team as a code owner May 23, 2024 03:20
Copy link

@xv-ian-c xv-ian-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xv-geoff-hb xv-geoff-hb merged commit c0c7cf2 into main May 27, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants