Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for static type hints and declare(strict_types=1); #1

Closed
tmotyl opened this issue Jan 8, 2020 · 1 comment
Closed

Check for static type hints and declare(strict_types=1); #1

tmotyl opened this issue Jan 8, 2020 · 1 comment

Comments

@tmotyl
Copy link

tmotyl commented Jan 8, 2020

It would be nice if the PHP_CodeSniffer actions are extended to check for static type hints and whether declare(strict_types=1); is missing.
e.g. using https://github.com/slevomat/coding-standard
https://github.com/slevomat/coding-standard#slevomatcodingstandardtypehintsdeclarestricttypes-

@fooman
Copy link
Contributor

fooman commented Jan 8, 2020

@tmotyl Thanks for your suggestion. This action is using the upstream Magento Coding Standard. I suggest following this issue here magento/magento-coding-standard#33 - once available it will be utilised by this github action as well.

@fooman fooman closed this as completed Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants