-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calling r functions in extension packages #238
Calling r functions in extension packages #238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me. I had a few minor comments and questions, see specific comments.
There are many ways we can optimise here when the time comes. We could even generate stubs for R libraries at compile time with something like:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks! Just saw one more minor typo.
If there are no objections, I'll merge. |
Yes, go ahead. |
Allow more flexible expressions in call! macros and update the Function
wrapper to accept primitives.