-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sliceiter #304
Remove sliceiter #304
Conversation
pub fn as_real_iter(&self) -> Option<Real> { | ||
self.as_real_slice() | ||
.map(|slice| Real::from_slice(self.to_owned(), slice)) | ||
pub fn as_real_iter(&self) -> Option<impl Iterator<Item = &f64>> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect to have here <Item = &Rfloat>
, similar to as_logical_iter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. Another PR, though.
I had conflicts with these extendr/extendr-api/src/robj/into_robj.rs Lines 300 to 324 in 4367764
And then I think here extendr/extendr-api/src/robj/into_robj.rs Lines 341 to 345 in 4367764
Will |
I'm inclined to retire There are changes coming to the language that will allow better specialisation of traits. |
This PR removes SliceIter and replaces Real and Int with Doubles and Integers.