-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register [[.rust_class
just as $.rust_class
#359
Register [[.rust_class
just as $.rust_class
#359
Conversation
Sounds good to me. |
This is great. Good to update the Change log, too. We may export trait methods to s3 methods in the future in which case we may optionally overload |
Sorry that I didn't notice there's a test package that needs to be checked. Now it should be ok. |
Thanks for updating. One more thing, could you add a small test to verify
|
@yutannihilation added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! I'll wait for a while before merging to see if there's any concern from other maintainers.
I'm merging now. Thanks for the contribution! |
Hi,
I believe it's necessary to register
[[
S3 method for exported Rust Class as well.The reason is that, only so, we can call the method dynamically, e.g.,
method <- "method_abc"; RustClass[[method]]()
.This is not possible for
$
.Thanks.