Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug trait for Rcplx and Complexes #444

Merged
merged 13 commits into from
Jan 11, 2023
Merged

Debug trait for Rcplx and Complexes #444

merged 13 commits into from
Jan 11, 2023

Conversation

Ilia-Kosenkov
Copy link
Member

@Ilia-Kosenkov Ilia-Kosenkov commented Jan 7, 2023 •
edited

  • Add proper Debug trait implementation for Rcplx
  • Add proper Debug trait implementation for Complexes
  • Add Rfloat::abs() function
  • Fix Rstr Debug implementation
  • Correct debug strings for NA values
  • Make Rany::Complexes wrap Complexes instead of Robj
  • Redirect Debug for Rany::Complexes to Debug implementation for Complexes
  • Add tests to check Debug implementation for scalars and vector wrappers

@Ilia-Kosenkov Ilia-Kosenkov marked this pull request as ready for review January 7, 2023 21:50
@Ilia-Kosenkov Ilia-Kosenkov mentioned this pull request Jan 7, 2023
Merged
3 tasks
@Ilia-Kosenkov Ilia-Kosenkov merged commit 13d81bf into extendr:master Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CGMossa CGMossa CGMossa approved these changes

@multimeric multimeric Awaiting requested review from multimeric

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ilia-Kosenkov @CGMossa